paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-05 06:23:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

notification_settings: Display streams that differ.

Browse Source 
The user has an option for setting global
notification settings as well as the same settings
for individual streams. Currently the user has to
keep track of each unmatched stream and then visit
each individual stream whose settings he wants to
update.

Thus this adds a dedicated UI table allowing the user
to view and update the notifications of the specific
streams which differs from the global settings.
It is located on the same page where the user defined
global notification settings can be modified.

Fixes #9228.
This commit is contained in:
Ryan Rehman
2020-03-12 22:10:38 +05:30
committed by Tim Abbott
parent e845b2364f
commit 9cb2475b53
6 changed files with 82 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
static/js/settings_notifications.js
View File

@@ -1,3 +1,5 @@
const render_stream_specific_notification_row = require('../templates/settings/stream_specific_notification_row.hbs');
const general_notifications_table_columns = [
/* An array of notification settings of any category like
* `stream_notification_settings` which makes a single row of
@@ -14,6 +16,14 @@ exports.stream_notification_settings = [
"wildcard_mentions_notify",
];
const stream_specific_notification_settings = [
"desktop_notifications",
"audible_notifications",
"push_notifications",
"email_notifications",
"wildcard_mentions_notify",
];
const pm_mention_notification_settings = [
"enable_desktop_notifications",
"enable_sounds",
@@ -90,6 +100,7 @@ exports.all_notifications = {
email_notification_settings: email_notification_settings,
},
show_push_notifications_tooltip: {
push_notifications: !page_params.realm_push_notifications_enabled,
enable_online_push_notifications: !page_params.realm_push_notifications_enabled,
},
};
@@ -109,6 +120,33 @@ exports.desktop_icon_count_display_values = {
},
};
function rerender_ui() {
const unmatched_streams_table = $("#stream-specific-notify-table");
if (unmatched_streams_table.length === 0) {
// If we haven't rendered "notification settings" yet, do nothing.
return;
}
const unmatched_streams = stream_data.get_unmatched_streams_for_notification_settings();
list_render.create(unmatched_streams_table, unmatched_streams, {
name: "unmatched-streams-list",
modifier: function (unmatched_streams) {
return render_stream_specific_notification_row({
stream: unmatched_streams,
stream_specific_notification_settings: stream_specific_notification_settings,
is_disabled: exports.all_notifications.show_push_notifications_tooltip,
});
},
}).init();
if (unmatched_streams.length === 0) {
unmatched_streams_table.css("display", "none");
} else {
unmatched_streams_table.css("display", "table-row-group");
}
}
function change_notification_setting(setting, setting_data, status_element) {
const data = {};
data[setting] = JSON.stringify(setting_data);
@@ -134,6 +172,10 @@ exports.set_up = function () {
e.preventDefault();
e.stopPropagation();
const input_elem = $(e.currentTarget);
if (input_elem.parents("#stream-specific-notify-table").length) {
stream_edit.stream_setting_clicked(e);
return;
}
const setting_name = input_elem.attr("name");
change_notification_setting(setting_name,
settings_org.get_input_element_value(this),
@@ -159,6 +201,7 @@ exports.set_up = function () {
}
});
exports.set_enable_digest_emails_visibility();
rerender_ui();
};
exports.update_page = function () {
@@ -175,6 +218,7 @@ exports.update_page = function () {
$("#" + setting).prop('checked', page_params[setting]);
}
rerender_ui();
};
window.settings_notifications = exports;