paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-13 02:17:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

message_fetch: Fix incorrectly set fetch status.

Browse Source 
We update the fetch status before reaching here, so it was
incorrect to return before adding messages to the message
list data since it is always cached.
This commit is contained in:
Aman Agrawal
2024-12-18 12:21:27 +05:30
committed by Tim Abbott
parent a95f419650
commit 9e519f8c18
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
web/src/message_fetch.ts
View File

@@ -229,9 +229,11 @@ function get_messages_success(data: MessageFetchResponse, opts: MessageFetchOpti
!opts.msg_list.should_preserve_current_rendered_state() &&
opts.msg_list !== message_lists.current
) {
// We unnarrowed before receiving new messages so
// don't bother processing the newly arrived messages.
return;
// We changed narrow before receiving new messages but
// since the message list data is cached, we just
// update the cached data and don't update the msg list.
opts.msg_list_data = opts.msg_list.data;
opts.msg_list = undefined;
}
if (!data) {
// The server occasionally returns no data during a