paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 13:03:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

webhooks: Rename UnexpectedWebhookEventType to UnsupportedWebhookEventType.

Browse Source 
Any exception is an "unexpected event", which means talking about
having an "unexpected event logger" or "unexpected event exception" is
confusing.  As the error message in `exceptions.py` already explains,
this is about an _unsupported_ event type.

This also switches the path that these exceptions are written to,
accordingly.
This commit is contained in:
Alex Vandiver
2020-08-19 13:26:38 -07:00
committed by Tim Abbott
parent 8016769613
commit 9ea9752e0e
33 changed files with 95 additions and 95 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
zerver/webhooks/basecamp/view.py
View File

@@ -5,7 +5,7 @@ from typing import Any, Dict
from django.http import HttpRequest, HttpResponse
from zerver.decorator import api_key_only_webhook_view
from zerver.lib.exceptions import UnexpectedWebhookEventType
from zerver.lib.exceptions import UnsupportedWebhookEventType
from zerver.lib.request import REQ, has_request_variables
from zerver.lib.response import json_success
from zerver.lib.webhooks.common import check_send_webhook_message
@@ -30,7 +30,7 @@ def api_basecamp_webhook(request: HttpRequest, user_profile: UserProfile,
event = get_event_type(payload)
if event not in SUPPORT_EVENTS:
raise UnexpectedWebhookEventType('Basecamp', event)
raise UnsupportedWebhookEventType('Basecamp', event)
subject = get_project_name(payload)
if event.startswith('document_'):
@@ -48,7 +48,7 @@ def api_basecamp_webhook(request: HttpRequest, user_profile: UserProfile,
elif event.startswith('comment_'):
body = get_comment_body(event, payload)
else:
raise UnexpectedWebhookEventType('Basecamp', event)
raise UnsupportedWebhookEventType('Basecamp', event)
check_send_webhook_message(request, user_profile, subject, body)
return json_success()