paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 13:33:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

message_edit.js: Change disabled fields to readonly to allow copying text.

Browse Source 
Previously we disabled fields in message_edit_form.handlebars that you
couldn't edit. This meant you could see the content of the field, but not
copy it. This commit marks those fields as readonly instead.
This commit is contained in:
Rishi Gupta
2016-11-02 09:34:02 -07:00
committed by Tim Abbott
parent 05d252da71
commit 9ed45eb4a1
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
static/js/message_edit.js
View File

@@ -176,17 +176,17 @@ function edit_message (row, raw_content) {
form.keydown(_.partial(handle_edit_keydown, false));
if (editability === editability_types.NO) {
row.find('textarea.message_edit_content').attr("disabled", "disabled");
row.find('input.message_edit_topic').attr("disabled", "disabled");
row.find('textarea.message_edit_content').prop("readonly", "readonly");
row.find('input.message_edit_topic').prop("readonly", "readonly");
} else if (editability === editability_types.NO_LONGER) {
// You can currently only reach this state in non-streams. If that
// changes (e.g. if we stop allowing topics to be modified forever
// in streams), then we'll need to disable
// row.find('input.message_edit_topic') as well.
row.find('textarea.message_edit_content').attr("disabled", "disabled");
row.find('textarea.message_edit_content').prop("readonly", "readonly");
row.find('.message_edit_countdown_timer').text(i18n.t("View source"));
} else if (editability === editability_types.TOPIC_ONLY) {
row.find('textarea.message_edit_content').attr("disabled", "disabled");
row.find('textarea.message_edit_content').prop("readonly", "readonly");
// Hint why you can edit the topic but not the message content
row.find('.message_edit_countdown_timer').text(i18n.t("Topic editing only"));
} else if (editability === editability_types.FULL) {
@@ -234,9 +234,9 @@ function edit_message (row, raw_content) {
var countdown_timer = setInterval(function () {
if (--seconds_left <= 0) {
clearInterval(countdown_timer);
message_content_row.attr("disabled","disabled");
message_content_row.prop("readonly", "readonly");
if (message.type === 'stream') {
message_topic_row.attr("disabled","disabled");
message_topic_row.prop("readonly", "readonly");
message_topic_propagate_row.hide();
}
// We don't go directly to a "TOPIC_ONLY" type state (with an active Save button),