paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 14:03:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

user_groups: Fix live-update of data when renaming groups.

Browse Source 
The "user_group_name_dict" value for the old group name key
was not deleted and this led to a bug where the stream creation
UI was incorrectly showing about a user group already existing
with the old group name.

Fixes #28108.
This commit is contained in:
Sahil Batra
2023-12-10 13:13:23 +05:30
committed by Tim Abbott
parent ce56e19d1c
commit 9fd5ed27fe
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
web/src/user_groups.ts
View File

@@ -69,8 +69,8 @@ export function get_user_group_from_id(group_id: number): UserGroup {
export function update(event: UserGroupUpdateEvent): void { export function update(event: UserGroupUpdateEvent): void {
const group = get_user_group_from_id(event.group_id); const group = get_user_group_from_id(event.group_id);
if (event.data.name !== undefined) { if (event.data.name !== undefined) {
group.name = event.data.name;
user_group_name_dict.delete(group.name); user_group_name_dict.delete(group.name);
group.name = event.data.name;
user_group_name_dict.set(group.name, group); user_group_name_dict.set(group.name, group);
} }
if (event.data.description !== undefined) { if (event.data.description !== undefined) {

2
web/tests/user_groups.test.js
View File

@@ -79,7 +79,7 @@ run_test("user_groups", () => {
}); });
assert.equal(user_groups.get_user_group_from_name(all.name), undefined); assert.equal(user_groups.get_user_group_from_name(all.name), undefined);
assert.equal(user_groups.get_user_group_from_name(admins.name).id, 1); assert.equal(user_groups.get_user_group_from_name("new admins").id, 1);
user_groups.add(all); user_groups.add(all);
const user_groups_array = user_groups.get_realm_user_groups(); const user_groups_array = user_groups.get_realm_user_groups();