paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-17 20:41:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

test_subs: Remove redundant cache_delete calls.

Browse Source 
These caches should be getting automatically invalidated upon
realm.save().
This commit is contained in:
Mateusz Mandera
2021-03-17 15:23:16 +01:00
committed by Tim Abbott
parent f147c42f9d
commit a094b80fb1
1 changed files with 0 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
zerver/tests/test_subs.py
View File

@@ -10,7 +10,6 @@ from django.http import HttpResponse
from django.utils.timezone import now as timezone_now from django.utils.timezone import now as timezone_now
from zerver.decorator import JsonableError from zerver.decorator import JsonableError
from zerver.lib import cache
from zerver.lib.actions import ( from zerver.lib.actions import (
bulk_add_subscriptions, bulk_add_subscriptions,
bulk_get_subscriber_user_ids, bulk_get_subscriber_user_ids,
@@ -3013,9 +3012,6 @@ class SubscriptionAPITest(ZulipTestCase):
self.test_realm.notifications_stream_id = notifications_stream.id self.test_realm.notifications_stream_id = notifications_stream.id
self.test_realm.save() self.test_realm.save()
# Delete the UserProfile from the cache so the realm change will be
# picked up
cache.cache_delete(cache.user_profile_by_email_cache_key(self.test_email))
with tornado_redirected_to_list(events): with tornado_redirected_to_list(events):
self.helper_check_subs_before_and_after_add( self.helper_check_subs_before_and_after_add(
self.streams + add_streams, self.streams + add_streams,
@@ -3066,10 +3062,6 @@ class SubscriptionAPITest(ZulipTestCase):
self.test_realm.notifications_stream_id = notifications_stream.id self.test_realm.notifications_stream_id = notifications_stream.id
self.test_realm.save() self.test_realm.save()
# Delete the UserProfile from the cache so the realm change will be
# picked up
cache.cache_delete(cache.user_profile_by_email_cache_key(invitee.email))
self.common_subscribe_to_streams( self.common_subscribe_to_streams(
invitee, invitee,
invite_streams, invite_streams,
@@ -3104,10 +3096,6 @@ class SubscriptionAPITest(ZulipTestCase):
user.realm = realm user.realm = realm
user.save() user.save()
# Delete the UserProfile from the cache so the realm change will be
# picked up
cache.cache_delete(cache.user_profile_by_email_cache_key(user.email))
self.common_subscribe_to_streams( self.common_subscribe_to_streams(
user, user,
invite_streams, invite_streams,