paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-20 14:38:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

notifications: Clean and automate global notifications update handler.

Browse Source 
To prevent specifying notifications individually for global
updates, automate handle_global_notification_updates using
settings_notifications.notification_settings where we have
the keys of all the types of notifications.
This commit is contained in:
Shubham Dhama
2018-03-08 12:20:16 +05:30
committed by Tim Abbott
parent c0f5ac801d
commit a0ab87bef2
2 changed files with 4 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
static/js/notifications.js
View File

@@ -658,28 +658,8 @@ exports.handle_global_notification_updates = function (notification_name, settin
// Update the global settings checked when determining if we should notify // Update the global settings checked when determining if we should notify
// for a given message. These settings do not affect whether or not a // for a given message. These settings do not affect whether or not a
// particular stream should receive notifications. // particular stream should receive notifications.
if (notification_name === "enable_stream_desktop_notifications") { if (settings_notifications.notification_settings.indexOf(notification_name) !== -1) {
page_params.enable_stream_desktop_notifications = setting; page_params[notification_name] = setting;
} else if (notification_name === "enable_stream_push_notifications") {
page_params.enable_stream_push_notifications = setting;
} else if (notification_name === "enable_stream_sounds") {
page_params.enable_stream_sounds = setting;
} else if (notification_name === "enable_desktop_notifications") {
page_params.enable_desktop_notifications = setting;
} else if (notification_name === "enable_sounds") {
page_params.enable_sounds = setting;
} else if (notification_name === "enable_offline_email_notifications") {
page_params.enable_offline_email_notifications = setting;
} else if (notification_name === "enable_offline_push_notifications") {
page_params.enable_offline_push_notifications = setting;
} else if (notification_name === "enable_online_push_notifications") {
page_params.enable_online_push_notifications = setting;
} else if (notification_name === "enable_digest_emails") {
page_params.enable_digest_emails = setting;
} else if (notification_name === "pm_content_in_desktop_notifications") {
page_params.pm_content_in_desktop_notifications = setting;
} else if (notification_name === "realm_name_in_notifications") {
page_params.realm_name_in_notifications = setting;
} }
}; };

4
static/js/settings_notifications.js
View File

@@ -22,7 +22,7 @@ var other_notification_settings = [
"realm_name_in_notifications", "realm_name_in_notifications",
]; ];
var notification_settings = other_notification_settings.concat( exports.notification_settings = other_notification_settings.concat(
pm_mention_notification_settings, pm_mention_notification_settings,
_.map(stream_notification_settings, function (item) { _.map(stream_notification_settings, function (item) {
return item.setting; return item.setting;
@@ -91,7 +91,7 @@ exports.set_up = function () {
}; };
function _update_page() { function _update_page() {
_.each(notification_settings, function (setting) { _.each(exports.notification_settings, function (setting) {
$("#" + setting).prop('checked', page_params[setting]); $("#" + setting).prop('checked', page_params[setting]);
}); });
} }