paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-05 22:43:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

stream_data: Modify is_user_subscribed to use stream id.

Browse Source 
This commit changes stream_data.is_user_subscribed to use stream id
instead of stream name.
We are using stream ids so that we can avoid bugs related to live
update after stream rename.
This commit is contained in:
sahil839
2020-07-09 01:58:35 +05:30
committed by Tim Abbott
parent 525b42cecc
commit a0d2c7db16
7 changed files with 30 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
static/js/compose.js
View File

@@ -746,7 +746,7 @@ exports.handle_keyup = function (event, textarea) {
rtl.set_rtl_class_for_textarea(textarea);
};
exports.needs_subscribe_warning = function (user_id, stream_name) {
exports.needs_subscribe_warning = function (user_id, stream_id) {
// This returns true if all of these conditions are met:
// * the user is valid
// * the user is not already subscribed to the stream
@@ -772,7 +772,7 @@ exports.needs_subscribe_warning = function (user_id, stream_name) {
return false;
}
if (stream_data.is_user_subscribed(stream_name, user_id)) {
if (stream_data.is_user_subscribed(stream_id, user_id)) {
// If our user is already subscribed
return false;
}
@@ -917,7 +917,7 @@ exports.warn_if_mentioning_unsubscribed_user = function (mentioned) {
return;
}
if (exports.needs_subscribe_warning(user_id, sub.name)) {
if (exports.needs_subscribe_warning(user_id, sub.stream_id)) {
const error_area = $("#compose_invite_users");
const existing_invites_area = $('#compose_invite_users .compose_invite_user');