paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-28 02:23:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

settings: Remove unused show_email parameter.

Browse Source 
We show "Email" column heading always in users list and
subscriber list irrespective of the email-address visibility
setting after 46660e5, so we do need to pass show_email
parameter to render_admin_tab and render_stream_settings.
This commit is contained in:
Sahil Batra
2021-11-09 23:29:22 +05:30
committed by Tim Abbott
parent 0ca49bc93a
commit a1a5a1643f
3 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
static/js/admin.js
View File

@@ -126,7 +126,6 @@ export function build_page() {
settings_send_digest_emails: page_params.settings_send_digest_emails, settings_send_digest_emails: page_params.settings_send_digest_emails,
realm_digest_emails_enabled: page_params.realm_digest_emails_enabled, realm_digest_emails_enabled: page_params.realm_digest_emails_enabled,
realm_digest_weekday: page_params.realm_digest_weekday, realm_digest_weekday: page_params.realm_digest_weekday,
show_email: settings_data.show_email(),
development: page_params.development_environment, development: page_params.development_environment,
zulip_plan_is_not_limited: page_params.zulip_plan_is_not_limited, zulip_plan_is_not_limited: page_params.zulip_plan_is_not_limited,
upgrade_text_for_wide_organization_logo: upgrade_text_for_wide_organization_logo:

1
static/js/stream_edit.js
View File

@@ -535,7 +535,6 @@ export function show_settings_for(node) {
other_settings, other_settings,
stream_post_policy_values: stream_data.stream_post_policy_values, stream_post_policy_values: stream_data.stream_post_policy_values,
message_retention_text: get_retention_policy_text_for_subscription_type(sub), message_retention_text: get_retention_policy_text_for_subscription_type(sub),
show_email: settings_data.show_email(),
}); });
ui.get_content_element($("#stream_settings")).html(html); ui.get_content_element($("#stream_settings")).html(html);

2
static/templates/stream_settings/stream_settings.hbs
View File

@@ -122,7 +122,7 @@
<div class="subscriber_settings stream_section"> <div class="subscriber_settings stream_section">
{{#with sub}} {{#with sub}}
<div class="subscription-members-setting"> <div class="subscription-members-setting">
{{> stream_members show_email=../show_email}} {{> stream_members}}
</div> </div>
{{/with}} {{/with}}
</div> </div>