paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-12 01:47:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

message_edit: Show inline topic edit spinner only via save handler.

Browse Source 
This commit delegates the responsibility of displaying a spinner to
the "save_inline_topic_edit" function.
This commit is contained in:
YashRE42
2020-04-18 22:23:45 +05:30
committed by Tim Abbott
parent ee68ac9957
commit a27e6aa673
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
static/js/click_handlers.js
View File

@@ -251,7 +251,6 @@ exports.initialize = function () {
}); });
$("body").on("click", ".topic_edit_save", function (e) { $("body").on("click", ".topic_edit_save", function (e) {
const recipient_row = $(this).closest(".recipient_row"); const recipient_row = $(this).closest(".recipient_row");
message_edit.show_topic_edit_spinner(recipient_row);
message_edit.save_inline_topic_edit(recipient_row); message_edit.save_inline_topic_edit(recipient_row);
e.stopPropagation(); e.stopPropagation();
popovers.hide_all(); popovers.hide_all();

3
static/js/message_edit.js
View File

@@ -209,7 +209,6 @@ function handle_inline_topic_edit_keydown(e) {
switch (code) { switch (code) {
case 13: // Handle enter key in the recipient bar/inline topic edit form case 13: // Handle enter key in the recipient bar/inline topic edit form
row = $(e.target).closest(".recipient_row"); row = $(e.target).closest(".recipient_row");
exports.show_topic_edit_spinner(row);
exports.save_inline_topic_edit(row); exports.save_inline_topic_edit(row);
e.stopPropagation(); e.stopPropagation();
e.preventDefault(); e.preventDefault();
@@ -519,6 +518,8 @@ exports.save_inline_topic_edit = function (row) {
return; return;
} }
exports.show_topic_edit_spinner(row);
if (message.locally_echoed) { if (message.locally_echoed) {
if (topic_changed) { if (topic_changed) {
echo.edit_locally(message, {new_topic: new_topic}); echo.edit_locally(message, {new_topic: new_topic});