From a33c98f23e4fb1e6e1f506d65b8c2a95523b49be Mon Sep 17 00:00:00 2001 From: Tim Abbott Date: Sat, 16 Sep 2017 03:14:56 -0700 Subject: [PATCH] push_notifications: Require the message.triggers fields to exist. The code was already assuming it implicitly, and making it explicit improves the readability. --- zerver/lib/push_notifications.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/zerver/lib/push_notifications.py b/zerver/lib/push_notifications.py index f487c90b27..aa9d16f9eb 100644 --- a/zerver/lib/push_notifications.py +++ b/zerver/lib/push_notifications.py @@ -399,11 +399,11 @@ def handle_push_notification(user_profile_id, missed_message): umessage = UserMessage.objects.get(user_profile=user_profile, message__id=missed_message['message_id']) message = umessage.message - triggers = missed_message.get('triggers') + triggers = missed_message['triggers'] message.triggers = { - 'private_message': triggers.get('private_message', False), - 'mentioned': triggers.get('mentioned', False), - 'stream_push_notify': triggers.get('stream_push_notify', False), + 'private_message': triggers['private_message'], + 'mentioned': triggers['mentioned'], + 'stream_push_notify': triggers['stream_push_notify'], } message.stream_name = missed_message.get('stream_name', None)