paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-15 19:31:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

compose: Move needs-empty-compose class to parent.

Browse Source 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg
2025-05-09 13:56:54 -07:00
committed by Tim Abbott
parent ef8f23aa05
commit a360ffd7f6
4 changed files with 8 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
web/src/compose.js
View File

@@ -137,9 +137,7 @@ export function clear_compose_box() {
compose_banner.clear_uploads(); compose_banner.clear_uploads();
compose_ui.hide_compose_spinner(); compose_ui.hide_compose_spinner();
scheduled_messages.reset_selected_schedule_timestamp(); scheduled_messages.reset_selected_schedule_timestamp();
$(".compose_control_button_container:has(.needs-empty-compose)").removeClass( $(".needs-empty-compose").removeClass("disabled-on-hover");
"disabled-on-hover",
);
} }
export function send_message_success(request, data) { export function send_message_success(request, data) {

8
web/src/compose_actions.ts
View File

@@ -144,9 +144,7 @@ function clear_box(): void {
compose_banner.clear_errors(); compose_banner.clear_errors();
compose_banner.clear_warnings(); compose_banner.clear_warnings();
compose_banner.clear_uploads(); compose_banner.clear_uploads();
$(".compose_control_button_container:has(.needs-empty-compose)").removeClass( $(".needs-empty-compose").removeClass("disabled-on-hover");
"disabled-on-hover",
);
// Reset send button status. // Reset send button status.
$("#compose-send-button").removeClass("disabled-message-send-controls"); $("#compose-send-button").removeClass("disabled-message-send-controls");
} }
@@ -397,9 +395,7 @@ export let start = (raw_opts: ComposeActionsStartOpts): void => {
false, false,
replace_all_without_undo_support, replace_all_without_undo_support,
); );
$(".compose_control_button_container:has(.needs-empty-compose)").addClass( $(".needs-empty-compose").addClass("disabled-on-hover");
"disabled-on-hover",
);
// If we were provided with message content, we might need to // If we were provided with message content, we might need to
// display that it's too long. // display that it's too long.
compose_validate.check_overflow_text($("#send_message_form")); compose_validate.check_overflow_text($("#send_message_form"));

6
web/src/compose_setup.js
View File

@@ -89,11 +89,7 @@ export function initialize() {
} }
// The poll widget requires an empty compose box. // The poll widget requires an empty compose box.
if (compose_text_length > 0) { $(".needs-empty-compose").toggleClass("disabled-on-hover", compose_text_length > 0);
$(".needs-empty-compose").parent().addClass("disabled-on-hover");
} else {
$(".needs-empty-compose").parent().removeClass("disabled-on-hover");
}
if (compose_state.get_is_content_unedited_restored_draft()) { if (compose_state.get_is_content_unedited_restored_draft()) {
compose_state.set_is_content_unedited_restored_draft(false); compose_state.set_is_content_unedited_restored_draft(false);

8
web/templates/compose_control_buttons.hbs
View File

@@ -55,11 +55,11 @@
</div> </div>
<div class="divider"></div> <div class="divider"></div>
{{#unless message_id}} {{#unless message_id}}
<div class="compose_control_button_container preview_mode_disabled" data-tooltip-template-id="add-poll-tooltip" data-tippy-maxWidth="none"> <div class="compose_control_button_container preview_mode_disabled needs-empty-compose" data-tooltip-template-id="add-poll-tooltip" data-tippy-maxWidth="none">
<a role="button" class="compose_control_button zulip-icon zulip-icon-poll add-poll needs-empty-compose" aria-label="{{t 'Add poll' }}" tabindex=0></a> <a role="button" class="compose_control_button zulip-icon zulip-icon-poll add-poll" aria-label="{{t 'Add poll' }}" tabindex=0></a>
</div> </div>
<div class="compose_control_button_container preview_mode_disabled" data-tooltip-template-id="add-todo-tooltip" data-tippy-maxWidth="none"> <div class="compose_control_button_container preview_mode_disabled needs-empty-compose" data-tooltip-template-id="add-todo-tooltip" data-tippy-maxWidth="none">
<a role="button" class="compose_control_button zulip-icon zulip-icon-todo-list add-todo-list needs-empty-compose" aria-label="{{t 'Add to-do list' }}" tabindex=0></a> <a role="button" class="compose_control_button zulip-icon zulip-icon-todo-list add-todo-list" aria-label="{{t 'Add to-do list' }}" tabindex=0></a>
</div> </div>
{{/unless}} {{/unless}}
<a role="button" class="compose_control_button compose_help_button zulip-icon zulip-icon-question" tabindex=0 data-tippy-content="{{t 'Message formatting' }}" data-overlay-trigger="message-formatting"></a> <a role="button" class="compose_control_button compose_help_button zulip-icon zulip-icon-question" tabindex=0 data-tippy-content="{{t 'Message formatting' }}" data-overlay-trigger="message-formatting"></a>