paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 15:03:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

FakeComposeBox: Extract instance vars for content/preview.

Browse Source 
Within FakeComposeBox I **mostly** want to keep the code
concrete (using explicit selectors), but these two
concepts are an exception to that rule:

    content textarea
    preview message area

In particular, for the DOM element that is the textarea
where you compose your message in markdown (i.e. the
main edit area), the real code has different ways of
expressing that in jQuery.

Since the content area is a singleton on the entire page,
a lot of code sensibly does an id search for the element.

There are some other pieces of code that do another
sensible thing, which is to search for the DOM element
within the container by the class name of .message-textarea.

This aliasing may cause some headaches down the road
for testing, but this commit should make it a little
easier to work around that in the future.
This commit is contained in:
Steve Howell
2025-01-08 12:38:50 +00:00
committed by Tim Abbott
parent a6f2197091
commit a3c76646b2
1 changed files with 21 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
web/tests/lib/compose_helpers.cjs
View File

@@ -7,19 +7,19 @@ const $ = require("./zjquery.cjs");
class FakeComposeBox { class FakeComposeBox {
constructor() { constructor() {
this.$content_textarea = $("textarea#compose-textarea");
this.$preview_message_area = $("#compose .preview_message_area");
// Simulate DOM relationships // Simulate DOM relationships
// stub_message_row($("textarea#compose-textarea")); $("#send_message_form").set_find_results(".message-textarea", this.$content_textarea);
$("#send_message_form").set_find_results(
".message-textarea",
$("textarea#compose-textarea"),
);
$("#send_message_form").set_find_results( $("#send_message_form").set_find_results(
".message-limit-indicator", ".message-limit-indicator",
$.create("limit-indicator-stub"), $.create("limit-indicator-stub"),
); );
const $message_row_stub = $.create("message_row_stub"); const $message_row_stub = $.create("message_row_stub");
$("textarea#compose-textarea").closest = (selector) => { this.$content_textarea.closest = (selector) => {
assert.equal(selector, ".message_row"); assert.equal(selector, ".message_row");
$message_row_stub.length = 0; $message_row_stub.length = 0;
return $message_row_stub; return $message_row_stub;
@@ -31,30 +31,31 @@ class FakeComposeBox {
reset() { reset() {
$("#compose_banners .user_not_subscribed").length = 0; $("#compose_banners .user_not_subscribed").length = 0;
$("textarea#compose-textarea").toggleClass = noop; this.$content_textarea.toggleClass = noop;
$("textarea#compose-textarea").set_height(50); this.$content_textarea.set_height(50);
$("#compose .preview_message_area").css = noop; this.$content_textarea.val("default message");
$("textarea#compose-textarea").val("default message"); this.$content_textarea.trigger("blur");
$("textarea#compose-textarea").trigger("blur");
this.$preview_message_area.css = noop;
$(".compose-submit-button .loader").show(); $(".compose-submit-button .loader").show();
} }
show_message_preview() { show_message_preview() {
this.$preview_message_area.show();
$("#compose .undo_markdown_preview").show(); $("#compose .undo_markdown_preview").show();
$("#compose .preview_message_area").show();
$("#compose .markdown_preview").hide(); $("#compose .markdown_preview").hide();
$("#compose").addClass("preview_mode"); $("#compose").addClass("preview_mode");
} }
hide_message_preview() { hide_message_preview() {
this.$preview_message_area.hide();
$("#compose .markdown_preview").show(); $("#compose .markdown_preview").show();
$("#compose .undo_markdown_preview").hide(); $("#compose .undo_markdown_preview").hide();
$("#compose .preview_message_area").hide();
$("#compose").removeClass("preview_mode"); $("#compose").removeClass("preview_mode");
} }
textarea_val() { textarea_val() {
return $("textarea#compose-textarea").val(); return this.$content_textarea.val();
} }
preview_content_html() { preview_content_html() {
@@ -74,11 +75,11 @@ class FakeComposeBox {
} }
set_textarea_val(val) { set_textarea_val(val) {
$("textarea#compose-textarea").val(val); this.$content_textarea.val(val);
} }
blur_textarea() { blur_textarea() {
$("textarea#compose-textarea").trigger("blur"); this.$content_textarea.trigger("blur");
} }
show_submit_button_spinner() { show_submit_button_spinner() {
@@ -86,7 +87,7 @@ class FakeComposeBox {
} }
set_textarea_toggle_class_function(f) { set_textarea_toggle_class_function(f) {
$("textarea#compose-textarea").toggleClass = f; this.$content_textarea.toggleClass = f;
} }
is_recipient_not_subscribed_banner_visible() { is_recipient_not_subscribed_banner_visible() {
@@ -94,7 +95,7 @@ class FakeComposeBox {
} }
is_textarea_focused() { is_textarea_focused() {
return $("textarea#compose-textarea").is_focused(); return this.$content_textarea.is_focused();
} }
is_submit_button_spinner_visible() { is_submit_button_spinner_visible() {
@@ -122,16 +123,16 @@ class FakeComposeBox {
} }
assert_preview_mode_is_off() { assert_preview_mode_is_off() {
assert.ok(!this.$preview_message_area.visible());
assert.ok(!$("#compose .undo_markdown_preview").visible()); assert.ok(!$("#compose .undo_markdown_preview").visible());
assert.ok(!$("#compose .preview_message_area").visible());
assert.ok($("#compose .markdown_preview").visible()); assert.ok($("#compose .markdown_preview").visible());
assert.ok(!$("#compose").hasClass("preview_mode")); assert.ok(!$("#compose").hasClass("preview_mode"));
} }
assert_preview_mode_is_on() { assert_preview_mode_is_on() {
assert.ok(this.$preview_message_area.visible());
assert.ok(!$("#compose .markdown_preview").visible()); assert.ok(!$("#compose .markdown_preview").visible());
assert.ok($("#compose .undo_markdown_preview").visible()); assert.ok($("#compose .undo_markdown_preview").visible());
assert.ok($("#compose .preview_message_area").visible());
assert.ok($("#compose").hasClass("preview_mode")); assert.ok($("#compose").hasClass("preview_mode"));
} }
} }