paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 21:43:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

user_groups: Make for_read required.

Browse Source 
We want to make the callers be more explicit about the use of the
user group being accessed, so that the later implemented database lock
can be benefited from the visibility.
This commit is contained in:
Zixuan James Li
2023-06-16 18:27:42 -04:00
committed by Tim Abbott
parent 37b3507b86
commit a3f4341934
3 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
zerver/actions/user_groups.py
View File

@@ -405,7 +405,7 @@ def do_send_delete_user_group_event(realm: Realm, user_group_id: int, realm_id:
def check_delete_user_group(
user_group_id: int, user_profile: UserProfile, *, acting_user: Optional[UserProfile]
) -> None:
user_group = access_user_group_by_id(user_group_id, user_profile)
user_group = access_user_group_by_id(user_group_id, user_profile, for_read=False)
user_group.delete()
do_send_delete_user_group_event(user_profile.realm, user_group_id, user_profile.realm.id)