From a3f46957bcc4308d0f0b5f4d42238a93b63069e9 Mon Sep 17 00:00:00 2001 From: Lalit Date: Thu, 18 May 2023 19:31:57 +0530 Subject: [PATCH] ts: Convert `confirm_dialog` module to TypeScript. --- tools/test-js-with-node | 2 +- web/src/{confirm_dialog.js => confirm_dialog.ts} | 3 ++- web/src/dialog_widget.ts | 4 ++-- 3 files changed, 5 insertions(+), 4 deletions(-) rename web/src/{confirm_dialog.js => confirm_dialog.ts} (74%) diff --git a/tools/test-js-with-node b/tools/test-js-with-node index 2267bc8bc1..1a9d7b83a2 100755 --- a/tools/test-js-with-node +++ b/tools/test-js-with-node @@ -72,7 +72,7 @@ EXEMPT_FILES = make_set( "web/src/compose_validate.js", "web/src/composebox_typeahead.js", "web/src/condense.js", - "web/src/confirm_dialog.js", + "web/src/confirm_dialog.ts", "web/src/copy_and_paste.js", "web/src/csrf.ts", "web/src/css_variables.js", diff --git a/web/src/confirm_dialog.js b/web/src/confirm_dialog.ts similarity index 74% rename from web/src/confirm_dialog.js rename to web/src/confirm_dialog.ts index 5d7e7ba294..f6ca1f2eec 100644 --- a/web/src/confirm_dialog.js +++ b/web/src/confirm_dialog.ts @@ -1,7 +1,8 @@ import * as dialog_widget from "./dialog_widget"; +import type {DialogWidgetConfig} from "./dialog_widget"; import {$t_html} from "./i18n"; -export function launch(conf) { +export function launch(conf: DialogWidgetConfig): void { dialog_widget.launch({ ...conf, close_on_submit: true, diff --git a/web/src/dialog_widget.ts b/web/src/dialog_widget.ts index 84ecf6401f..aeb244d5ab 100644 --- a/web/src/dialog_widget.ts +++ b/web/src/dialog_widget.ts @@ -43,7 +43,7 @@ import * as ui_report from "./ui_report"; * to DOM, it can do so by passing a post_render hook. */ -type WidgetConfig = { +export type DialogWidgetConfig = { html_heading: string; html_body: string; on_click: (e: unknown) => void; @@ -97,7 +97,7 @@ export function close_modal(on_hidden_callback?: () => void): void { overlays.close_modal("dialog_widget_modal", {on_hidden: on_hidden_callback}); } -export function launch(conf: WidgetConfig): void { +export function launch(conf: DialogWidgetConfig): void { // Mandatory fields: // * html_heading // * html_body