paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 15:03:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

settings: Pass a single object to settings_notifications functions.

Browse Source 
We refactor the code for user notification settings and realm-level
defaults of notification settings to pass a single object consisting
of container element, settings object, url and for_realm_settings
bool variable, to the functions, instead of passing them as separate
variables.
This commit is contained in:
Sahil Batra
2021-09-20 19:26:32 +05:30
committed by Tim Abbott
parent e43d469e9a
commit a44e7a1a60
6 changed files with 34 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
static/js/settings_realm_user_settings_defaults.js
View File

@@ -23,7 +23,7 @@ export function maybe_disable_widgets() {
export function set_up() {
const container = $(realm_default_settings_panel.container);
settings_display.set_up(realm_default_settings_panel);
settings_notifications.set_up(container, realm_user_settings_defaults, true);
settings_notifications.set_up(realm_default_settings_panel);
container.find(".presence_enabled").on("change", (e) => {
e.preventDefault();
@@ -58,5 +58,7 @@ export function initialize() {
realm_default_settings_panel.container = "#realm-user-default-settings";
realm_default_settings_panel.settings_object = realm_user_settings_defaults;
realm_default_settings_panel.patch_url = "/json/realm/user_settings_defaults";
realm_default_settings_panel.notification_sound_elem =
"#realm-default-notification-sound-audio";
realm_default_settings_panel.for_realm_settings = true;
}