paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 21:43:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

settings: Avoid dropdown_list_widget on same line as labels.

Browse Source 
The 3 instances of dropdown_list_widget using the `label` property had
different design than the rest of all of our dropdowns, in that the
label was on the same line as the dropdown.

Fix this by adjusting the `label` option to use our standard
`dropdown-title` CSS class.

Also remove the colons in the labels.

I confirmed that these were the only instances of this widget using
the label feature.

Fixes #20415.
This commit is contained in:
Tim Abbott
2022-03-15 16:08:41 -07:00
parent d150236217
commit a4d42392a6
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
static/templates/settings/dropdown_list_widget.hbs
View File

@@ -1,7 +1,7 @@
<div class="input-group dropdown-list-widget" id="{{widget_name}}_widget">
<span class="{{widget_name}}_setting dropup actual-dropdown-menu prop-element" id="id_{{widget_name}}" aria-labelledby="{{widget_name}}_label">
{{#if label}}
<label id="{{widget_name}}_label" class="inline-block">
<label id="{{widget_name}}_label" class="dropdown-title">
{{ label }}
</label>
{{/if}}