paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 06:53:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

performance: Use values_list for message edits.

Browse Source
This commit is contained in:
Steve Howell
2021-05-12 17:01:54 +00:00
committed by Tim Abbott
parent bbcf396303
commit a518cea65d
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
zerver/lib/actions.py
View File

@@ -5982,7 +5982,7 @@ def do_update_message(
# All users that are subscribed to the stream must be # All users that are subscribed to the stream must be
# notified when a message is edited # notified when a message is edited
subscriber_ids = [user.user_profile_id for user in subscriptions] subscriber_ids = set(subscriptions.values_list("user_profile_id", flat=True))
if new_stream is not None: if new_stream is not None:
# TODO: Guest users don't see the new moved topic # TODO: Guest users don't see the new moved topic
@@ -6004,9 +6004,9 @@ def do_update_message(
subscriptions = subscriptions.exclude( subscriptions = subscriptions.exclude(
user_profile_id__in=[sub.user_profile_id for sub in old_stream_unsubbed_guests] user_profile_id__in=[sub.user_profile_id for sub in old_stream_unsubbed_guests]
) )
subscriber_ids = [user.user_profile_id for user in subscriptions] subscriber_ids = set(subscriptions.values_list("user_profile_id", flat=True))
users_to_be_notified += list(map(subscriber_info, subscriber_ids)) users_to_be_notified += list(map(subscriber_info, sorted(list(subscriber_ids))))
send_event(user_profile.realm, event, users_to_be_notified) send_event(user_profile.realm, event, users_to_be_notified)