paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 21:43:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Clean up viewport_center hack.

Browse Source
This commit is contained in:
Steve Howell
2019-02-15 18:15:03 +00:00
committed by Tim Abbott
parent c7e03f9a71
commit a537f4a075
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
static/js/emoji_picker.js
View File

@@ -573,6 +573,13 @@ exports.render_emoji_popover = function (elt, id) {
};
var placement = popovers.compute_placement(elt, APPROX_HEIGHT, APPROX_WIDTH, true);
if (placement === 'viewport_center') {
// For legacy reasons `compute_placement` actually can
// return `viewport_center`, but bootstrap doesn't actually
// support that.
placement = 'left';
}
var template = templates.render('emoji_popover', template_args);
// if the window is mobile sized, add the `.popover-flex` wrapper to the emoji
@@ -583,7 +590,7 @@ exports.render_emoji_popover = function (elt, id) {
elt.popover({
// temporary patch for handling popover placement of `viewport_center`
placement: placement === 'viewport_center' ? 'left' : placement,
placement: placement,
template: template,
title: "",
content: generate_emoji_picker_content(id),