paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-14 19:06:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

server_events_dispatch: Remove body fade out on changing theme.

Browse Source 
This causes the app to scroll to top and causes slow paint.
This commit is contained in:
Aman Agrawal
2023-05-26 14:14:52 +00:00
committed by Tim Abbott
parent 03a0a7abc6
commit a55c1ab2da
2 changed files with 0 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
web/src/server_events_dispatch.js
View File

@@ -716,7 +716,6 @@ export function dispatch_normal_event(event) {
unread_ui.update_unread_banner(); unread_ui.update_unread_banner();
} }
if (event.property === "color_scheme") { if (event.property === "color_scheme") {
$("body").fadeOut(300);
setTimeout(() => { setTimeout(() => {
if (event.value === settings_config.color_scheme_values.night.code) { if (event.value === settings_config.color_scheme_values.night.code) {
dark_theme.enable(); dark_theme.enable();
@@ -728,7 +727,6 @@ export function dispatch_normal_event(event) {
dark_theme.default_preference_checker(); dark_theme.default_preference_checker();
realm_logo.render(); realm_logo.render();
} }
$("body").fadeIn(300);
message_lists.update_recipient_bar_background_color(); message_lists.update_recipient_bar_background_color();
}, 300); }, 300);
} }

7
web/tests/dispatch.test.js
View File

@@ -874,13 +874,6 @@ run_test("user_settings", ({override}) => {
assert_same(user_settings.dense_mode, true); assert_same(user_settings.dense_mode, true);
assert_same(toggled, ["less_dense_mode", "more_dense_mode"]); assert_same(toggled, ["less_dense_mode", "more_dense_mode"]);
$("body").fadeOut = (secs) => {
assert_same(secs, 300);
};
$("body").fadeIn = (secs) => {
assert_same(secs, 300);
};
override(realm_logo, "render", noop); override(realm_logo, "render", noop);
{ {