paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 23:13:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

tooltips: Remove unnecessary checks for message action buttons in tippy.

Browse Source 
We handled tooltips for failed message action buttons separately
through our default tippy-zulip-tooltip class because of
a diffrent html structure for these buttons. But as we refactored
html for those buttons to have same structure as for other buttons
in message action this extra check is no more needed.
This commit is contained in:
m-e-l-u-h-a-n
2021-07-17 19:17:31 +05:30
committed by Tim Abbott
parent e7b1de8ace
commit a63a23087f
1 changed files with 1 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
static/js/tippyjs.js
View File

@@ -140,14 +140,7 @@ export function initialize() {
const edit_button = elem.find("i.edit_content_button"); const edit_button = elem.find("i.edit_content_button");
content = edit_button.attr("data-tippy-content"); content = edit_button.attr("data-tippy-content");
} }
if (content === undefined) {
// If content is still undefined it is because content
// is specified on inner i tags and is handled by our
// general tippy-zulip-tooltip class. So we return
// false here to avoid showing an extra empty tooltip
// for such cases.
return false;
}
instance.setContent(content); instance.setContent(content);
return true; return true;
}, },