paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 04:53:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

settings: Remove broken default streams error handler.

Browse Source 
For unknown reasons, 6f7b973d3b
introduced an invalid semi-duplicate call to ui_report.error that
passed the wrong number of parameters.

We should just call `ui_report.error`, which already had logic to
handle the distinction between 40x and 50x errors.

Fixes an issue reported in #18273.
This commit is contained in:
Tim Abbott
2021-04-27 23:15:38 -07:00
parent 9dd88e845a
commit a6f4230895
1 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
static/js/settings_streams.js
View File

@@ -80,11 +80,7 @@ function make_stream_default(stream_id) {
url: "/json/default_streams",
data,
error(xhr) {
if (xhr.status.toString().charAt(0) === "4") {
ui_report.error($t_html({defaultMessage: "Failed"}), xhr, default_stream_status);
} else {
ui_report.error($t_html({defaultMessage: "Failed"}), default_stream_status);
}
ui_report.error($t_html({defaultMessage: "Failed"}), xhr, default_stream_status);
default_stream_status.show();
},
});