paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-05 22:43:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Speed up filter_people_by_search_terms.

Browse Source 
We now call build_person_matcher outside the loop.
This commit is contained in:
Steve Howell
2019-12-23 14:49:41 +00:00
committed by Tim Abbott
parent 9c525f8ecb
commit a718b47095
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
static/js/people.js
View File

@@ -795,6 +795,12 @@ exports.build_person_matcher = function (query) {
exports.filter_people_by_search_terms = function (users, search_terms) { exports.filter_people_by_search_terms = function (users, search_terms) {
const filtered_users = new Dict(); const filtered_users = new Dict();
// Build our matchers outside the loop to avoid some
// search overhead that is not user-specific.
const matchers = _.map(search_terms, function (search_term) {
return exports.build_person_matcher(search_term);
});
// Loop through users and populate filtered_users only // Loop through users and populate filtered_users only
// if they include search_terms // if they include search_terms
_.each(users, function (user) { _.each(users, function (user) {
@@ -805,8 +811,8 @@ exports.filter_people_by_search_terms = function (users, search_terms) {
} }
// Return user emails that include search terms // Return user emails that include search terms
const match = _.any(search_terms, function (search_term) { const match = _.any(matchers, function (matcher) {
return exports.person_matches_query(user, search_term); return matcher(user);
}); });
if (match) { if (match) {