mirror of
https://github.com/zulip/zulip.git
synced 2025-11-05 06:23:38 +00:00
webhooks: Remove the legacy GitHub integration.
The github-services model for how GitHub would send requests to this legacy integration is no longer available since earlier in 2019. Removing this integration also allows us to finally remove authenticated_api_view, the legacy authentication model from 2013 that had been used for this integration (and other features long since upgraded). A few functions that were used by the Beanstalk webhook are moved into that webhook's implementation directly.
This commit is contained in:
@@ -204,36 +204,6 @@ class HubotIntegration(Integration):
|
||||
legacy=legacy
|
||||
)
|
||||
|
||||
class GithubIntegration(WebhookIntegration):
|
||||
"""
|
||||
We need this class to don't creating url object for git integrations.
|
||||
We want to have one generic url with dispatch function for github service and github webhook.
|
||||
"""
|
||||
def __init__(self, name: str, categories: List[str], client_name: Optional[str]=None,
|
||||
logo: Optional[str]=None, secondary_line_text: Optional[str]=None,
|
||||
function: Optional[str]=None, url: Optional[str]=None,
|
||||
display_name: Optional[str]=None, doc: Optional[str]=None,
|
||||
stream_name: Optional[str]=None, legacy: Optional[bool]=False) -> None:
|
||||
url = self.DEFAULT_URL.format(name='github')
|
||||
|
||||
super().__init__(
|
||||
name,
|
||||
categories,
|
||||
client_name=client_name,
|
||||
logo=logo,
|
||||
secondary_line_text=secondary_line_text,
|
||||
function=function,
|
||||
url=url,
|
||||
display_name=display_name,
|
||||
doc=doc,
|
||||
stream_name=stream_name,
|
||||
legacy=legacy
|
||||
)
|
||||
|
||||
@property
|
||||
def url_object(self) -> None:
|
||||
return
|
||||
|
||||
class EmbeddedBotIntegration(Integration):
|
||||
'''
|
||||
This class acts as a registry for bots verified as safe
|
||||
@@ -303,7 +273,7 @@ WEBHOOK_INTEGRATIONS = [
|
||||
WebhookIntegration('flock', ['customer-support'], display_name='Flock'),
|
||||
WebhookIntegration('freshdesk', ['customer-support']),
|
||||
WebhookIntegration('front', ['customer-support'], display_name='Front'),
|
||||
GithubIntegration(
|
||||
WebhookIntegration(
|
||||
'github',
|
||||
['version-control'],
|
||||
display_name='GitHub',
|
||||
|
||||
Reference in New Issue
Block a user