eslint: Enable prefer-arrow-callback.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg
2020-07-01 16:45:54 -07:00
committed by Tim Abbott
parent 960174408f
commit a79322bc94
160 changed files with 873 additions and 1012 deletions

View File

@@ -135,7 +135,7 @@ exports.append_custom_profile_fields = function (element_id, user_id) {
[all_field_types.URL.id, "url"],
]);
all_custom_fields.forEach(function (field) {
all_custom_fields.forEach((field) => {
let field_value = people.get_custom_profile_data(user_id, field.id);
const is_choice_field = field.type === all_field_types.CHOICE.id;
const field_choices = [];
@@ -200,7 +200,7 @@ exports.initialize_custom_user_type_fields = function (element_id, user_id, is_e
return user_pills;
}
page_params.custom_profile_fields.forEach(function (field) {
page_params.custom_profile_fields.forEach((field) => {
let field_value_raw = people.get_custom_profile_data(user_id, field.id);
if (field_value_raw) {
@@ -229,7 +229,7 @@ exports.initialize_custom_user_type_fields = function (element_id, user_id, is_e
if (field_value_raw) {
const field_value = JSON.parse(field_value_raw);
if (field_value) {
field_value.forEach(function (pill_user_id) {
field_value.forEach((pill_user_id) => {
const user = people.get_by_user_id(pill_user_id);
user_pill.append_user(user, pills);
});
@@ -240,11 +240,11 @@ exports.initialize_custom_user_type_fields = function (element_id, user_id, is_e
const input = pill_container.children('.input');
if (set_handler_on_update) {
user_pill.set_up_typeahead_on_pills(input, pills, update_custom_user_field);
pills.onPillRemove(function () {
pills.onPillRemove(() => {
update_custom_user_field();
});
} else {
user_pill.set_up_typeahead_on_pills(input, pills, function () {});
user_pill.set_up_typeahead_on_pills(input, pills, () => {});
}
}
user_pills.set(field.id, pills);
@@ -277,7 +277,7 @@ exports.set_up = function () {
exports.add_custom_profile_fields_to_settings();
$("#account-settings-status").hide();
const setup_api_key_modal = _.once(function () {
const setup_api_key_modal = _.once(() => {
function request_api_key(data) {
channel.post({
url: '/json/fetch_api_key',
@@ -308,7 +308,7 @@ exports.set_up = function () {
// Skip the password prompt step, since the user doesn't have one.
request_api_key({});
} else {
$("#get_api_key_button").on("click", function (e) {
$("#get_api_key_button").on("click", (e) => {
const data = {};
e.preventDefault();
e.stopPropagation();
@@ -318,7 +318,7 @@ exports.set_up = function () {
});
}
$("#show_api_key").on("click", "button.regenerate_api_key", function (e) {
$("#show_api_key").on("click", "button.regenerate_api_key", (e) => {
channel.post({
url: '/json/users/me/api_key/regenerate',
success: function (data) {
@@ -343,7 +343,7 @@ exports.set_up = function () {
});
});
$('#api_key_button').click(function (e) {
$('#api_key_button').click((e) => {
setup_api_key_modal();
overlays.open_modal('#api_key_modal');
e.preventDefault();
@@ -359,7 +359,7 @@ exports.set_up = function () {
clear_password_change();
$("#change_full_name").on('click', function (e) {
$("#change_full_name").on('click', (e) => {
e.preventDefault();
e.stopPropagation();
if (exports.user_can_change_name()) {
@@ -368,7 +368,7 @@ exports.set_up = function () {
}
});
$('#change_password').on('click', function (e) {
$('#change_password').on('click', (e) => {
e.preventDefault();
e.stopPropagation();
overlays.open_modal('#change_password_modal');
@@ -376,24 +376,24 @@ exports.set_up = function () {
if (page_params.realm_password_auth_enabled !== false) {
// zxcvbn.js is pretty big, and is only needed on password
// change, so load it asynchronously.
require(['zxcvbn'], function (zxcvbn) {
require(['zxcvbn'], (zxcvbn) => {
window.zxcvbn = zxcvbn;
$('#pw_strength .bar').removeClass("fade");
});
}
});
$('#change_password_modal').find('[data-dismiss=modal]').on('click', function () {
$('#change_password_modal').find('[data-dismiss=modal]').on('click', () => {
clear_password_change();
});
// If the modal is closed using the 'close' button or the 'Cancel' button
$('.modal').find('[data-dismiss=modal]').on('click', function () {
$('.modal').find('[data-dismiss=modal]').on('click', () => {
// Enable mouse events for the background on closing modal
$('.overlay.show').attr("style", null);
});
$('#change_password_button').on('click', function (e) {
$('#change_password_button').on('click', (e) => {
e.preventDefault();
e.stopPropagation();
const change_password_error = $('#change_password_modal').find(".change_password_info").expectOne();
@@ -431,12 +431,12 @@ exports.set_up = function () {
clear_password_change();
});
$('#new_password').on('input', function () {
$('#new_password').on('input', () => {
const field = $('#new_password');
common.password_quality(field.val(), $('#pw_strength .bar'), field);
});
$("#change_full_name_button").on('click', function (e) {
$("#change_full_name_button").on('click', (e) => {
e.preventDefault();
e.stopPropagation();
const change_full_name_error = $('#change_full_name_modal').find(".change_full_name_info").expectOne();
@@ -454,7 +454,7 @@ exports.set_up = function () {
$('#account-settings-status').expectOne(), opts);
});
$('#change_email_button').on('click', function (e) {
$('#change_email_button').on('click', (e) => {
e.preventDefault();
e.stopPropagation();
const change_email_error = $('#change_email_modal').find(".change_email_info").expectOne();
@@ -477,7 +477,7 @@ exports.set_up = function () {
$('#account-settings-status').expectOne(), opts);
});
$('#change_email').on('click', function (e) {
$('#change_email').on('click', (e) => {
e.preventDefault();
e.stopPropagation();
if (!page_params.realm_email_changes_disabled || page_params.is_admin) {
@@ -487,7 +487,7 @@ exports.set_up = function () {
}
});
$("#user_deactivate_account_button").on('click', function (e) {
$("#user_deactivate_account_button").on('click', (e) => {
// This click event must not get propagated to parent container otherwise the modal
// will not show up because of a call to `close_active_modal` in `settings.js`.
e.preventDefault();
@@ -495,7 +495,7 @@ exports.set_up = function () {
$("#deactivate_self_modal").modal("show");
});
$('#account-settings').on('click', '.custom_user_field .remove_date', function (e) {
$('#account-settings').on('click', '.custom_user_field .remove_date', (e) => {
e.preventDefault();
e.stopPropagation();
const field = $(e.target).closest('.custom_user_field').expectOne();
@@ -516,7 +516,7 @@ exports.set_up = function () {
}
});
$("#do_deactivate_self_button").on('click', function () {
$("#do_deactivate_self_button").on('click', () => {
$("#do_deactivate_self_button .loader").css('display', 'inline-block');
$("#do_deactivate_self_button span").hide();
$("#do_deactivate_self_button object").on("load", function () {
@@ -525,7 +525,7 @@ exports.set_up = function () {
$svg.find("rect").css("fill", "#000");
});
setTimeout(function () {
setTimeout(() => {
channel.del({
url: '/json/users/me',
success: function () {
@@ -550,22 +550,22 @@ exports.set_up = function () {
}, 5000);
});
$("#show_my_user_profile_modal").on('click', function () {
$("#show_my_user_profile_modal").on('click', () => {
overlays.close_overlay("settings");
const user = people.get_by_user_id(people.my_current_user_id());
setTimeout(function () {
setTimeout(() => {
popovers.show_user_profile(user);
}, 100);
// If user opened the "preview profile" modal from user
// settings, then closing preview profile modal should
// send them back to the settings modal.
$('body').one('hidden.bs.modal', '#user-profile-modal', function (e) {
$('body').one('hidden.bs.modal', '#user-profile-modal', (e) => {
e.preventDefault();
e.stopPropagation();
popovers.hide_user_profile();
setTimeout(function () {
setTimeout(() => {
if (!overlays.settings_open()) {
overlays.open_settings();
}