paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 14:03:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

push_notifications: Don't open unnecessary APNs connections.

Browse Source 
Calling `get_apns_context` opens (and caches) an open connection to
the APNs servers.  Since `apns_enabled` is called from Django
codepaths, this means that the Django processes hold unnecessary
connections open to the APNs servers.

Switch `apns_enabled` to checking what `get_apns_context` checks when
we're just returning True/False.
This commit is contained in:
Alex Vandiver
2022-02-07 23:21:49 -08:00
committed by Tim Abbott
parent e032b38661
commit a80840aa4d
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
zerver/lib/push_notifications.py
View File

@@ -78,7 +78,7 @@ def get_apns_context() -> Optional[APNsContext]:
# which fills the logs; see https://github.com/Fatal1ty/aioapns/issues/15
logging.getLogger("aioapns").setLevel(logging.CRITICAL)
if settings.APNS_CERT_FILE is None:
if settings.APNS_CERT_FILE is None: # nocoverage
return None
# NB if called concurrently, this will make excess connections.
@@ -99,7 +99,7 @@ def get_apns_context() -> Optional[APNsContext]:
def apns_enabled() -> bool:
return get_apns_context() is not None
return settings.APNS_CERT_FILE is not None
def modernize_apns_payload(data: Dict[str, Any]) -> Dict[str, Any]: