paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 13:03:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

emoji: Rename css_class to emoji_code in emoji.js.

Browse Source 
Now that `emoji_collection` and `emojis_by_name` are global
datasources in the webapp we need to rename things carefully
to reflect their actual meaning. The fact that emoji code is
used as a css class for unicode emoji is one thing but it is
not its sole use so renaming it seems a good idea.
This commit is contained in:
Harshit Bansal
2018-07-20 16:38:56 +00:00
committed by Tim Abbott
parent 88bc78645d
commit a906d564a3
4 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
frontend_tests/node_tests/templates.js
View File

@@ -693,7 +693,7 @@ run_test('emoji_popover_content', () => {
has_reacted: false,
is_realm_emoji: false,
name: '100',
css_class: '100',
emoji_code: '100',
},
],
},
@@ -733,13 +733,13 @@ run_test('emoji_popover_search_results', () => {
has_reacted: false,
is_realm_emoji: false,
name: 'test-1',
css_class: 'test-1',
emoji_code: 'test-1',
},
{
has_reacted: true,
is_realm_emoji: false,
name: 'test-2',
css_class: 'test-2',
emoji_code: 'test-2',
},
],
};
@@ -756,7 +756,7 @@ run_test('emoji_showcase', () => {
emoji_dict: {
name: "thumbs_up",
is_realm_emoji: false,
css_class: "1f44d",
emoji_code: "1f44d",
has_reacted: false,
},
};