paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 05:53:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use user's current full name when rendering messages.

Browse Source 
The field message.sender_full_name can be out of date, so
we recompute is using data from people.js in
add_message_metadata().
This commit is contained in:
Steve Howell
2017-01-24 14:10:01 -08:00
committed by showell
parent 97243dcd52
commit a98cbff788
3 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
frontend_tests/node_tests/message_store.js
View File

@@ -50,6 +50,7 @@ var message_store = require('js/message_store.js');
(function test_add_message_metadata() { (function test_add_message_metadata() {
var message = { var message = {
sender_email: 'me@example.com', sender_email: 'me@example.com',
sender_id: me.user_id,
type: 'private', type: 'private',
display_recipient: [me, bob, cindy], display_recipient: [me, bob, cindy],
flags: ['has_alert_word'], flags: ['has_alert_word'],

5
static/js/message_store.js
View File

@@ -111,6 +111,11 @@ function add_message_metadata(message) {
people.extract_people_from_message(message); people.extract_people_from_message(message);
var sender = people.get_person_from_user_id(message.sender_id);
if (sender) {
message.sender_full_name = sender.full_name;
}
switch (message.type) { switch (message.type) {
case 'stream': case 'stream':
message.is_stream = true; message.is_stream = true;

4
static/js/people.js
View File

@@ -28,6 +28,10 @@ exports.init = function () {
exports.init(); exports.init();
exports.get_person_from_user_id = function (user_id) { exports.get_person_from_user_id = function (user_id) {
if (!people_by_user_id_dict.has(user_id)) {
blueslip.error('Unknown user_id in get_person_from_user_id: ' + user_id);
return undefined;
}
return people_by_user_id_dict.get(user_id); return people_by_user_id_dict.get(user_id);
}; };