paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-18 12:54:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

condense: Clean up continue/else/if idiom.

Browse Source 
If an `if` calls continue, then you don't need
the clutter of an `else`.  (I wonder if eslint
can enforce these the same way it does for
return/else.)
This commit is contained in:
Steve Howell
2020-04-02 13:47:15 +00:00
committed by Tim Abbott
parent ca9a416e38
commit a9a16932ec
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
static/js/condense.js
View File

@@ -210,10 +210,14 @@ exports.condense_and_collapse = function (elems) {
if (message.condensed === true) { if (message.condensed === true) {
condense_row($(elem)); condense_row($(elem));
continue; continue;
} else if (message.condensed === false) { }
if (message.condensed === false) {
uncondense_row($(elem)); uncondense_row($(elem));
continue; continue;
} else if (long_message) { }
if (long_message) {
// By default, condense a long message. // By default, condense a long message.
condense_row($(elem)); condense_row($(elem));
} else { } else {