paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 13:33:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

default_streams: Remove get_default_streams_for_realm_as_dicts.

Browse Source 
Since get_default_streams_for_realm_as_dicts function was only
used in tests, this commit removes it and updates the test to
use the function which returns Stream objects instead of dicts.

This commit also removes Stream.to_dict function which is no
longer used.
This commit is contained in:
Sahil Batra
2024-12-17 14:46:27 +05:30
committed by Tim Abbott
parent 1182e7e350
commit a9bd614df3
5 changed files with 8 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
zerver/tests/test_signup.py
View File

@@ -32,7 +32,7 @@ from zerver.actions.realm_settings import (
from zerver.actions.users import change_user_is_active, do_change_user_role, do_deactivate_user
from zerver.decorator import do_two_factor_login
from zerver.forms import HomepageForm, check_subdomain_available
from zerver.lib.default_streams import get_default_streams_for_realm_as_dicts
from zerver.lib.default_streams import get_slim_realm_default_streams
from zerver.lib.email_notifications import enqueue_welcome_emails
from zerver.lib.i18n import get_default_language_for_new_user
from zerver.lib.initial_password import initial_password
@@ -3995,9 +3995,7 @@ class UserSignUpTest(ZulipTestCase):
stream_name = "Rome"
realm = get_realm("zulip")
stream = get_stream(stream_name, realm)
default_stream_names = {
stream["name"] for stream in get_default_streams_for_realm_as_dicts(realm.id)
}
default_stream_names = {stream.name for stream in get_slim_realm_default_streams(realm.id)}
self.assertNotIn(stream_name, default_stream_names)
# Invite user.