paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 05:23:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

default_streams: Remove get_default_streams_for_realm_as_dicts.

Browse Source 
Since get_default_streams_for_realm_as_dicts function was only
used in tests, this commit removes it and updates the test to
use the function which returns Stream objects instead of dicts.

This commit also removes Stream.to_dict function which is no
longer used.
This commit is contained in:
Sahil Batra
2024-12-17 14:46:27 +05:30
committed by Tim Abbott
parent 1182e7e350
commit a9bd614df3
5 changed files with 8 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
zerver/tests/test_subs.py
View File

@@ -54,7 +54,7 @@ from zerver.lib.attachments import (
)
from zerver.lib.default_streams import (
get_default_stream_ids_for_realm,
get_default_streams_for_realm_as_dicts,
get_slim_realm_default_streams,
)
from zerver.lib.email_mirror_helpers import encode_email_address_helper
from zerver.lib.exceptions import JsonableError
@@ -3443,8 +3443,8 @@ class StreamAdminTest(ZulipTestCase):
class DefaultStreamTest(ZulipTestCase):
def get_default_stream_names(self, realm: Realm) -> set[str]:
streams = get_default_streams_for_realm_as_dicts(realm.id)
return {s["name"] for s in streams}
streams = get_slim_realm_default_streams(realm.id)
return {s.name for s in streams}
def test_query_count(self) -> None:
DefaultStream.objects.all().delete()
@@ -3457,13 +3457,6 @@ class DefaultStreamTest(ZulipTestCase):
new_stream_ids.add(stream.id)
do_add_default_stream(stream)
with queries_captured() as queries:
default_streams = get_default_streams_for_realm_as_dicts(realm.id)
self.assert_length(queries, 1)
self.assert_length(default_streams, 5)
self.assertEqual({dct["stream_id"] for dct in default_streams}, new_stream_ids)
with queries_captured() as queries:
default_stream_ids = get_default_stream_ids_for_realm(realm.id)