paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 05:53:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

user_topics: Update user_topics.js to include all visibility policies.

Browse Source 
Updated user_topics.js to include all visibility policies
rather than just mute/inherit visibility policies.

Replaced muted_topics Map with `all_user_topics` Map which has
structure: {stream_id:{topic_name:{date_updated,visibility_policy}}}.

Removed add_muted_topic, remove_muted_topic functions which were
adding/removing topics in muted_topics Map. Added new function
update_user_topics which take parameter stream_id, topic,
visibility_policy, and date_updated(optional) which adds a topic
to all_user_topics with date_updated and visibility_policy,
if visibility_policy is not equal to inherit.
else, removes topic from all_user_topics.

Added get_topic_visibility_policy which returns visibility_policy
if stream_id is not undefined else return false.

Added 2 helper functions is_topic_muted and is_topic_unmuted which
uses get_topic_visibility_policy and return true if topic is
muted and unmuted respectively else return false.

Replaced switch case statement which was using add_muted_topic
and remove_muted_topic functions in set_user_topic with new function
update_user_topics.

Fixes #24244
This commit is contained in:
Hardik Dharmani
2023-04-11 11:18:13 +05:30
committed by Tim Abbott
parent 46cabdd59e
commit aab252f657
6 changed files with 98 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
web/tests/notifications.test.js
View File

@@ -47,7 +47,11 @@ const muted = {
stream_data.add_sub(general);
stream_data.add_sub(muted);
user_topics.add_muted_topic(general.stream_id, "muted topic");
user_topics.update_user_topics(
general.stream_id,
"muted topic",
user_topics.all_visibility_policies.MUTED,
);
function test(label, f) {
run_test(label, (helpers) => {