From aadd42f9e861f5becbae185bda40eaa56737f5e5 Mon Sep 17 00:00:00 2001 From: Nikhil Maske Date: Wed, 27 Jan 2021 12:04:22 +0530 Subject: [PATCH] design: Adjust the visibility of the spinner icon. The spinner icon is not visible until the user clicks on topic_edit_save, so the space alloted to spinner-icon looks empty for rest of the time. To improve the design, the spinner icon is only shown when the user clicks on topic_edit_save. --- static/js/message_edit.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/static/js/message_edit.js b/static/js/message_edit.js index 3ebc75dfdf..c73a545da4 100644 --- a/static/js/message_edit.js +++ b/static/js/message_edit.js @@ -175,6 +175,7 @@ exports.show_topic_edit_spinner = function (row) { spinner.css({height: ""}); $(".topic_edit_save").hide(); $(".topic_edit_cancel").hide(); + $(".topic_edit_spinner").show(); }; exports.hide_topic_move_spinner = function () { @@ -549,6 +550,7 @@ exports.start_topic_edit = function (recipient_row) { const form = $(render_topic_edit_form()); current_msg_list.show_edit_topic_on_recipient_row(recipient_row, form); form.on("keydown", handle_inline_topic_edit_keydown); + $(".topic_edit_spinner").hide(); const msg_id = rows.id_for_recipient_row(recipient_row); const message = current_msg_list.get(msg_id); let topic = message.topic;