paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 13:33:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

user groups: Make name and description optional in group update.

Browse Source 
View that handled `PATCH user_groups/<int:user_group_id>` required
both name and description parameters to be passed. Due to this
clients had to pass values for both these parameters even if
one of them was changed.

To resolve this name description parameters to
`PATCH user_groups/<int:user_group_id>` are made optional.
This commit is contained in:
m-e-l-u-h-a-n
2023-02-26 21:17:58 +05:30
committed by Tim Abbott
parent 508ac58dc0
commit ab4e6a94c5
5 changed files with 22 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
zerver/views/user_groups.py
View File

@@ -1,4 +1,4 @@
from typing import Sequence
from typing import Optional, Sequence
from django.http import HttpRequest, HttpResponse
from django.utils.translation import gettext as _
@@ -62,18 +62,18 @@ def edit_user_group(
request: HttpRequest,
user_profile: UserProfile,
user_group_id: int = REQ(json_validator=check_int, path_only=True),
name: str = REQ(default=""),
description: str = REQ(default=""),
name: Optional[str] = REQ(default=None),
description: Optional[str] = REQ(default=None),
) -> HttpResponse:
if not (name or description):
if name is None and description is None:
raise JsonableError(_("No new data supplied"))
user_group = access_user_group_by_id(user_group_id, user_profile)
if name != user_group.name:
if name is not None and name != user_group.name:
do_update_user_group_name(user_group, name, acting_user=user_profile)
if description != user_group.description:
if description is not None and description != user_group.description:
do_update_user_group_description(user_group, description, acting_user=user_profile)
return json_success(request)