paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-18 21:48:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

dict: Reimplement Dict using Map.

Browse Source 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
This commit is contained in:
Anders Kaseorg
2020-02-02 22:05:56 -08:00
committed by Tim Abbott
parent b16222a38b
commit ab61222dd5
1 changed files with 13 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
static/js/dict.ts
View File

@@ -1,61 +1,49 @@
import * as _ from 'underscore';
type KeyValue<V> = { k: string; v: V };
type Items<V> = {
[key: string]: KeyValue<V>;
};
export class Dict<V> { export class Dict<V> {
private _items: Items<V> = {}; private _items: Map<string, V> = new Map();
get(key: string): V | undefined { get(key: string): V | undefined {
const mapping = this._items[this._munge(key)]; return this._items.get(this._munge(key));
if (mapping === undefined) {
return undefined;
}
return mapping.v;
} }
set(key: string, value: V): V { set(key: string, value: V): V {
this._items[this._munge(key)] = {k: key, v: value}; this._items.set(this._munge(key), value);
return value; return value;
} }
has(key: string): boolean { has(key: string): boolean {
return _.has(this._items, this._munge(key)); return this._items.has(this._munge(key));
} }
del(key: string): void { del(key: string): void {
delete this._items[this._munge(key)]; this._items.delete(this._munge(key));
} }
keys(): string[] { keys(): string[] {
return _.pluck(_.values(this._items), 'k'); return [...this._items.keys()];
} }
values(): V[] { values(): V[] {
return _.pluck(_.values(this._items), 'v'); return [...this._items.values()];
} }
items(): [string, V][] { items(): [string, V][] {
return _.map(_.values(this._items), return [...this._items];
(mapping: KeyValue<V>): [string, V] => [mapping.k, mapping.v]);
} }
num_items(): number { num_items(): number {
return _.keys(this._items).length; return this._items.size;
} }
is_empty(): boolean { is_empty(): boolean {
return _.isEmpty(this._items); return this._items.size === 0;
} }
each(f: (v: V, k?: string) => void): void { each(f: (v: V, k?: string) => void): void {
_.each(this._items, (mapping: KeyValue<V>) => f(mapping.v, mapping.k)); this._items.forEach(f);
} }
clear(): void { clear(): void {
this._items = {}; this._items.clear();
} }
// Convert keys to strings and handle undefined. // Convert keys to strings and handle undefined.
@@ -70,6 +58,6 @@ export class Dict<V> {
key = (key as object).toString(); key = (key as object).toString();
} }
return ':' + key; return key;
} }
} }