paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-05 22:43:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

stream settings: Extract enable_subscriber_management.

Browse Source 
The name here is accounting for future plans where
we will share code for both of these use cases:

    * editing subscribers on current stream (now)
    * editing subscribers on new stream (upcoming)
This commit is contained in:
Steve Howell
2021-12-15 15:12:08 +00:00
committed by Tim Abbott
parent 931a8f28a0
commit ab8b550cda
1 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
static/js/stream_edit.js
View File

@@ -389,7 +389,6 @@ export function get_text_from_item(item) {
} }
function show_subscription_settings(sub) { function show_subscription_settings(sub) {
const stream_id = sub.stream_id;
const edit_container = stream_settings_containers.get_edit_container(sub); const edit_container = stream_settings_containers.get_edit_container(sub);
const colorpicker = edit_container.find(".colorpicker"); const colorpicker = edit_container.find(".colorpicker");
@@ -401,7 +400,13 @@ function show_subscription_settings(sub) {
return; return;
} }
const pill_container = edit_container.find(".pill-container"); enable_subscriber_management({sub, parent_container: edit_container});
}
function enable_subscriber_management({sub, parent_container}) {
const stream_id = sub.stream_id;
const pill_container = parent_container.find(".pill-container");
pill_widget = input_pill.create({ pill_widget = input_pill.create({
container: pill_container, container: pill_container,
@@ -413,10 +418,10 @@ function show_subscription_settings(sub) {
stream_ui_updates.initialize_cant_subscribe_popover(sub); stream_ui_updates.initialize_cant_subscribe_popover(sub);
} }
// fetch subscriber list from memory. // fetch subscriber list from memory.
const list = get_subscriber_list(edit_container); const list = get_subscriber_list(parent_container);
list.empty(); list.empty();
const user_ids = peer_data.get_subscribers(sub.stream_id); const user_ids = peer_data.get_subscribers(stream_id);
const users = get_users_from_subscribers(user_ids); const users = get_users_from_subscribers(user_ids);
sort_but_pin_current_user_on_top(users); sort_but_pin_current_user_on_top(users);