paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 23:13:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

tutorial: don't start the tutorial until you're subbed to the tutorial stream.

Browse Source 
Also handle the case of subscribing failing.

This race could cause you to not see initial traffic from the tutorial bot.

(imported from commit 395a2968555e20a4dbc106dfa9d5790e9f102a3e)
This commit is contained in:
Jessica McKellar
2013-04-12 17:04:49 -04:00
parent 1c437cb0ff
commit ac4385e410
1 changed files with 25 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
zephyr/static/js/tutorial.js
View File

@@ -226,12 +226,6 @@ function run_tutorial(stepNumber) {
}
}
function add_to_tutorial_stream() {
if ($.inArray(my_tutorial_stream, subs.subscribed_streams()) === -1) {
subs.tutorial_subscribe_or_add_me_to(my_tutorial_stream);
}
}
function set_tutorial_status(status, callback) {
$.ajax({
type: 'POST',
@@ -241,15 +235,35 @@ function set_tutorial_status(status, callback) {
});
}
function start_tutorial() {
tutorial_running = true;
run_tutorial(0);
set_tutorial_status("started");
}
function end_tutorial() {
subs.tutorial_unsubscribe_me_from(my_tutorial_stream);
tutorial_running = false;
set_tutorial_status("finished", function () {
// We need to reload the streams list so the sidebar is populated
// with the new streams
subs.reload_subscriptions({clear_first: true})
.fail(function () {
blueslip.error("Unable to load subs after tutorial.");
});
});
}
exports.start = function () {
if (tutorial_running) {
// Not more than one of these at once!
return;
}
tutorial_running = true;
add_to_tutorial_stream();
run_tutorial(0);
set_tutorial_status("started");
if ($.inArray(my_tutorial_stream, subs.subscribed_streams()) === -1) {
subs.tutorial_subscribe_or_add_me_to(my_tutorial_stream)
.then(start_tutorial, end_tutorial);
}
};
// This technique is not actually that awesome, because it's pretty
@@ -264,13 +278,7 @@ exports.start = function () {
// the tutorial if you still need it.
exports.stop = function () {
if (tutorial_running) {
subs.tutorial_unsubscribe_me_from(my_tutorial_stream);
tutorial_running = false;
set_tutorial_status("finished", function () {
// We need to reload the streams list so the sidebar is populated
// with the new streams
subs.reload_subscriptions({clear_first: true});
});
end_tutorial();
}
};