paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-15 11:22:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

copy_messages: Rename select_div for clarity.

Browse Source
This commit is contained in:
Tim Abbott
2025-03-10 14:30:51 -07:00
parent 26355df8e9
commit acaddc2d4e
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
web/src/copy_messages.ts
View File

@@ -109,7 +109,7 @@ function construct_copy_div($div: JQuery, start_id: number, end_id: number): voi
} }
} }
function select_div($div: JQuery, selection: Selection): void { function insert_and_select_div($div: JQuery, selection: Selection): void {
$div.css({ $div.css({
position: "absolute", position: "absolute",
left: "-99999px", left: "-99999px",
@@ -245,7 +245,6 @@ export function copy_handler(): void {
const start_id = analysis.start_id; const start_id = analysis.start_id;
const end_id = analysis.end_id; const end_id = analysis.end_id;
const skip_same_td_check = analysis.skip_same_td_check; const skip_same_td_check = analysis.skip_same_td_check;
const $div = $("<div>");
if (start_id === undefined || end_id === undefined || start_id > end_id) { if (start_id === undefined || end_id === undefined || start_id > end_id) {
// In this case either the starting message or the ending // In this case either the starting message or the ending
@@ -282,11 +281,12 @@ export function copy_handler(): void {
// chance for overlaps between same message ids, avoiding which is much // chance for overlaps between same message ids, avoiding which is much
// more difficult since we can get a range (start_id and end_id) for // more difficult since we can get a range (start_id and end_id) for
// each selection `Range`. // each selection `Range`.
const $div = $("<div>");
construct_copy_div($div, start_id, end_id); construct_copy_div($div, start_id, end_id);
// Select div so that the browser will copy it // Select div so that the browser will copy it
// instead of copying the original selection // instead of copying the original selection
select_div($div, selection); insert_and_select_div($div, selection);
// eslint-disable-next-line @typescript-eslint/no-deprecated // eslint-disable-next-line @typescript-eslint/no-deprecated
document.execCommand("copy"); document.execCommand("copy");
setTimeout(() => { setTimeout(() => {