paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-11 17:36:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

actions: Fix misleading comment about wildcard mentions.

Browse Source 
Having the `wildcard_mentions_notify` setting turned on does
not necessarily mean that the user will receive notification
for that message. There is more nuance to this, as explained
in the updated comment.
This commit is contained in:
Abhijeet Prasad Bodas
2021-12-18 14:55:15 +05:30
committed by Tim Abbott
parent 2393342e03
commit acdce4df47
1 changed files with 5 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
zerver/lib/actions.py
View File

@@ -1620,15 +1620,11 @@ def get_recipient_info(
if possible_wildcard_mention: if possible_wildcard_mention:
# If there's a possible wildcard mention, we need to # If there's a possible wildcard mention, we need to
# determine which users would receive a wildcard mention # determine the set of users who have enabled the
# notification for this message should the message indeed # "wildcard_mentions_notify" setting (that is, the set of
# contain a wildcard mention. # users for whom wildcard mentions should be treated like
# # personal mentions for notifications). This setting
# We don't have separate values for push/email # applies to both email and push notifications.
# notifications here; at this stage, we're just
# determining whether this wildcard mention should be
# treated as a mention (and follow the user's mention
# notification preferences) or a normal message.
wildcard_mention_user_ids = { wildcard_mention_user_ids = {
row["user_profile_id"] row["user_profile_id"]
for row in subscription_rows for row in subscription_rows