paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-14 19:06:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

unread_ops: Add unread class to messages instead of a full rerender.

Browse Source 
When user marks messages as unread, we used to rerender them but
that was not required since we only need to add `unread` class
to their `message_row` to achieve the same effect.
This commit is contained in:
Aman Agrawal
2023-04-21 02:04:06 +00:00
committed by Tim Abbott
parent c8f1325281
commit ace3ca80a8
2 changed files with 13 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
web/src/message_list_view.js
View File

@@ -1587,4 +1587,13 @@ export class MessageListView {
} }
$row.removeClass("unread"); $row.removeClass("unread");
} }
show_messages_as_unread(message_ids) {
const $table = rows.get_table(this.table_name);
const $rows_to_show_as_unread = $table.find(".message_row").filter((index, $row) => {
const message_id = Number.parseFloat($row.getAttribute("zid"));
return message_ids.includes(message_id);
});
$rows_to_show_as_unread.addClass("unread");
}
} }

20
web/src/unread_ops.js
View File

@@ -10,7 +10,6 @@ import {$t_html} from "./i18n";
import * as loading from "./loading"; import * as loading from "./loading";
import * as message_flags from "./message_flags"; import * as message_flags from "./message_flags";
import * as message_lists from "./message_lists"; import * as message_lists from "./message_lists";
import * as message_live_update from "./message_live_update";
import * as message_store from "./message_store"; import * as message_store from "./message_store";
import * as message_viewport from "./message_viewport"; import * as message_viewport from "./message_viewport";
import * as narrow_state from "./narrow_state"; import * as narrow_state from "./narrow_state";
@@ -331,22 +330,11 @@ export function process_unread_messages_event({message_ids, message_details}) {
}); });
} }
/* // Update UI for the messages marked as unread.
A batch of messages marked as unread can be 1000+ messages, so for (const list of message_lists.all_rendered_message_lists()) {
we do want to do a bulk operation for these UI updates. list.view.show_messages_as_unread(message_ids);
}
We use a big-hammer approach now to updating the message view.
This is relatively harmless, since the only time we are called is
when the user herself marks her message as unread. But we
do eventually want to be more surgical here, especially once we
have a final scheme for how best to structure the HTML within
the message to indicate read-vs.-unread. Currently we use a
green border, but that may change.
The main downside of doing a full rerender is that it can be
user-visible in the form of users' avatars flickering.
*/
message_live_update.rerender_messages_view_by_message_ids(message_ids);
recent_topics_ui.complete_rerender(); recent_topics_ui.complete_rerender();
if ( if (