From aceee3da11b79bfc34d5af3231ab46082b6ce77d Mon Sep 17 00:00:00 2001 From: Eklavya Sharma Date: Fri, 17 Jun 2016 21:20:52 +0530 Subject: [PATCH] zerver/lib/rate_limiter.py: Annotate rate_limiter.rules. After annotating rate_limiter.rules, mypy complained that rules does not support cmp. So use key to customize sort instead of cmp. Python docs also recommend using key over cmp. --- zerver/lib/rate_limiter.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/zerver/lib/rate_limiter.py b/zerver/lib/rate_limiter.py index c32b0eb68e..968407637c 100644 --- a/zerver/lib/rate_limiter.py +++ b/zerver/lib/rate_limiter.py @@ -17,7 +17,7 @@ import logging # http://blog.domaintools.com/2013/04/rate-limiting-with-redis/ client = get_redis_client() -rules = settings.RATE_LIMITING_RULES +rules = settings.RATE_LIMITING_RULES # type: List[Tuple[int, int]] def _rules_for_user(user): # type: (UserProfile) -> List[Tuple[int, int]] if user.rate_limits != "": @@ -49,7 +49,7 @@ def add_ratelimit_rule(range_seconds, num_requests): global rules rules.append((range_seconds, num_requests)) - rules.sort(cmp=lambda x, y: x[0] < y[0]) + rules.sort(key=lambda x: x[0]) def remove_ratelimit_rule(range_seconds, num_requests): # type: (int , int) -> None