paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-13 18:36:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

compose: Remove old style compose send disable.

Browse Source 
We now use `disabled-message-send-controls` class to control
the disabled status of send button. So, this is not required.
This commit is contained in:
Aman Agrawal
2025-03-21 19:50:00 +05:30
committed by Tim Abbott
parent 753b4e31b9
commit ad0b616bbd
4 changed files with 0 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
web/src/compose_setup.js
View File

@@ -40,7 +40,6 @@ import * as user_topics from "./user_topics.ts";
import * as widget_modal from "./widget_modal.ts"; import * as widget_modal from "./widget_modal.ts";
export function abort_xhr() { export function abort_xhr() {
$("#compose-send-button").prop("disabled", false);
upload.compose_upload_cancel(); upload.compose_upload_cancel();
} }

2
web/src/compose_validate.ts
View File

@@ -715,8 +715,6 @@ export function validate_stream_message_mentions(opts: StreamWildcardOptions): b
if (!user_acknowledged_stream_wildcard) { if (!user_acknowledged_stream_wildcard) {
show_stream_wildcard_warnings(opts); show_stream_wildcard_warnings(opts);
$("#compose-send-button").prop("disabled", false);
compose_ui.hide_compose_spinner(); compose_ui.hide_compose_spinner();
return false; return false;
} }

3
web/tests/compose_validate.test.cjs
View File

@@ -155,7 +155,6 @@ function stub_message_row($textarea) {
function initialize_pm_pill(mock_template) { function initialize_pm_pill(mock_template) {
$.clear_all_elements(); $.clear_all_elements();
$("#compose-send-button").prop("disabled", false);
$("#compose-send-button").trigger("focus"); $("#compose-send-button").trigger("focus");
$("#compose-send-button .loader").hide(); $("#compose-send-button .loader").hide();
@@ -303,7 +302,6 @@ test_ui("validate", ({mock_template, override}) => {
}; };
assert.ok(!compose_validate.validate()); assert.ok(!compose_validate.validate());
assert.ok(!$("#compose-send-button .loader").visible()); assert.ok(!$("#compose-send-button .loader").visible());
assert.equal($("#compose-send-button").prop("disabled"), false);
compose_validate.validate(); compose_validate.validate();
// Now add content to compose, and expect to see the banner. // Now add content to compose, and expect to see the banner.
@@ -455,7 +453,6 @@ test_ui("validate_stream_message", ({override, override_rewire, mock_template})
override(realm, "realm_can_mention_many_users_group", everyone.id); override(realm, "realm_can_mention_many_users_group", everyone.id);
compose_state.message_content("Hey @**all**"); compose_state.message_content("Hey @**all**");
assert.ok(!compose_validate.validate()); assert.ok(!compose_validate.validate());
assert.equal($("#compose-send-button").prop("disabled"), false);
assert.ok(stream_wildcard_warning_rendered); assert.ok(stream_wildcard_warning_rendered);
let wildcards_not_allowed_rendered = false; let wildcards_not_allowed_rendered = false;

2
web/tests/upload.test.cjs
View File

@@ -152,8 +152,6 @@ test("show_error_message", ({mock_template}) => {
return "<banner-stub>"; return "<banner-stub>";
}); });
$("#compose-send-button").prop("disabled", true);
upload.show_error_message(upload.compose_config, "Error message"); upload.show_error_message(upload.compose_config, "Error message");
assert.ok(!$("#compose-send-button").hasClass("disabled-message-send-controls")); assert.ok(!$("#compose-send-button").hasClass("disabled-message-send-controls"));
assert.ok(banner_shown); assert.ok(banner_shown);