paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-05 06:23:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

sqlalchemy_utils: Remove NonClosingPool.recreate override.

Browse Source 
There doesn’t seem to be a reason to override this, and the upstream
method it was based on has diverged since this was written.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg
2022-02-09 20:08:51 -08:00
committed by Tim Abbott
parent 29330c180a
commit ad232c9b65
1 changed files with 0 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
zerver/lib/sqlalchemy_utils.py
View File

@@ -17,16 +17,6 @@ class NonClosingPool(sqlalchemy.pool.NullPool):
def _do_return_conn(self, conn: sqlalchemy.engine.base.Connection) -> None:
pass
def recreate(self) -> "NonClosingPool":
return self.__class__(
creator=self._creator, # type: ignore[attr-defined] # implementation detail
recycle=self._recycle, # type: ignore[attr-defined] # implementation detail
reset_on_return=self._reset_on_return, # type: ignore[attr-defined] # implementation detail
echo=self.echo,
logging_name=self._orig_logging_name, # type: ignore[attr-defined] # implementation detail
_dispatch=self.dispatch, # type: ignore[attr-defined] # implementation detail
)
sqlalchemy_engine: Optional[Engine] = None