From ad26247247cb18e15e06a75f6b4ca9f86d2c38d0 Mon Sep 17 00:00:00 2001 From: N-Shar-ma Date: Fri, 27 Oct 2023 18:08:59 +0530 Subject: [PATCH] =?UTF-8?q?compose:=20Add=20a=20placeholder=20"is=20?= =?UTF-8?q?=E2=80=A6"=20for=20the=20`/me`=20slash=20command.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixes: #27399. --- tools/lib/capitalization.py | 1 + web/src/composebox_typeahead.js | 1 + web/tests/composebox_typeahead.test.js | 3 ++- 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/lib/capitalization.py b/tools/lib/capitalization.py index 8da2bfc13e..f1bdc97700 100644 --- a/tools/lib/capitalization.py +++ b/tools/lib/capitalization.py @@ -74,6 +74,7 @@ IGNORED_PHRASES = [ r"user@example\.com", r"acme", # Fragments of larger strings + r"is …", r"your subscriptions on your Streams page", r"Add global time
Everyone sees global times in their own time zone\.", r"user", diff --git a/web/src/composebox_typeahead.js b/web/src/composebox_typeahead.js index 30e18f4355..9b8495b481 100644 --- a/web/src/composebox_typeahead.js +++ b/web/src/composebox_typeahead.js @@ -445,6 +445,7 @@ export const slash_commands = [ text: $t({defaultMessage: "/me is excited (Display action text)"}), name: "me", aliases: "", + placeholder: $t({defaultMessage: "is …"}), }, { text: $t({defaultMessage: "/poll Where should we go to lunch today? (Create a poll)"}), diff --git a/web/tests/composebox_typeahead.test.js b/web/tests/composebox_typeahead.test.js index 9831c5df06..503ee90021 100644 --- a/web/tests/composebox_typeahead.test.js +++ b/web/tests/composebox_typeahead.test.js @@ -182,6 +182,7 @@ const me_slash = { name: "me", aliases: "", text: "translated: /me is excited (Display action text)", + placeholder: "translated: is …", }; const my_slash = { @@ -576,7 +577,7 @@ test("content_typeahead_selected", ({override}) => { fake_this.query = "/m"; fake_this.completing = "slash"; actual_value = ct.content_typeahead_selected.call(fake_this, me_slash); - expected_value = "/me "; + expected_value = "/me translated: is …"; assert.equal(actual_value, expected_value); fake_this.query = "/da";