puppet: Move analytics cron job to analytics.pp.

This better groups it with the related code.

puppet/zulip/manifests/analytics.pp

@@ -1,6 +1,6 @@
 # Default configuration for a Zulip app frontend
+# This should only be enabled on exactly 1 Zulip server in a cluster.
 class zulip::analytics {
-  # This should only be enabled on exactly 1 Zulip server in a cluster.
   file { "/etc/cron.d/update-analytics-counts":
     ensure => file,
     owner  => "root",
@@ -8,4 +8,12 @@ class zulip::analytics {
     mode => 644,
     source => "puppet:///modules/zulip/cron.d/update-analytics-counts",
   }
+
+  file { "/etc/cron.d/check-analytics-state":
+    ensure => file,
+    owner  => "root",
+    group  => "root",
+    mode => 644,
+    source => "puppet:///modules/zulip/cron.d/check-analytics-state",
+  }
 }

puppet/zulip/manifests/app_frontend.pp

@@ -62,14 +62,6 @@ class zulip::app_frontend {
     source => "puppet:///modules/zulip/cron.d/soft-deactivate-users",
   }
 
-  file { "/etc/cron.d/check-analytics-state":
-    ensure => file,
-    owner  => "root",
-    group  => "root",
-    mode => 644,
-    source => "puppet:///modules/zulip/cron.d/check-analytics-state",
-  }
-
   file { "/etc/cron.d/calculate-first-visible-message-id":
     ensure => file,
     owner  => "root",