mirror of
https://github.com/zulip/zulip.git
synced 2025-11-05 22:43:42 +00:00
events: Fix zulip_finish to not make assumptions about how queues work.
Previously, we had an issue with the ACKing protocol, where if a virtualizable event (like a "read" flag) was dispatched to a queue client immediately, we would not properly ACK the change because it had been made a virtual event. (imported from commit ea09812f8a5ba1d5aad65f536022e3dbc77b0f9e)
This commit is contained in:
@@ -95,7 +95,7 @@ class ClientDescriptor(object):
|
||||
try:
|
||||
self.current_handler._request._log_data['extra'] = "[%s/1]" % (self.event_queue.id,)
|
||||
self.current_handler.zulip_finish(dict(result='success', msg='',
|
||||
events=[event],
|
||||
events=self.event_queue.contents(),
|
||||
queue_id=self.event_queue.id),
|
||||
self.current_handler._request,
|
||||
apply_markdown=self.apply_markdown)
|
||||
|
||||
Reference in New Issue
Block a user