paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-10 17:07:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove some GitHub hook hacks for old customers.

Browse Source 
These features are in most cases possible to setup directly via our
GitHub services integration UI, and the customers aren't using Zulip
anymore, so this is worth doing to clean up the code.

(imported from commit 1e6f4ec523d85b6233a8e5b4eaa13eacfbe6e5f4)
This commit is contained in:
Tim Abbott
2015-09-20 11:44:03 -07:00
parent b68d116e3a
commit ade363f3af
1 changed files with 1 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
zerver/views/webhooks.py
View File

@@ -179,8 +179,7 @@ def api_github_landing(request, user_profile, event=REQ,
if domain == "customer26.invalid" and short_ref: if domain == "customer26.invalid" and short_ref:
kwargs['topic_focus'] = short_ref kwargs['topic_focus'] = short_ref
# CUSTOMER18 has requested not to get pull request notifications if event == 'pull_request' and exclude_pull_requests:
if (event == 'pull_request' and domain in ['customer18.invalid']) or exclude_pull_requests:
return json_success() return json_success()
# Only Zulip, CUSTOMER5, CUSTOMER27, and CUSTOMER17 get issues right now # Only Zulip, CUSTOMER5, CUSTOMER27, and CUSTOMER17 get issues right now
@@ -188,14 +187,6 @@ def api_github_landing(request, user_profile, event=REQ,
if event == 'issues' and domain not in ('zulip.com', 'customer5.invalid', 'customer27.invalid', 'customer17.invalid') or exclude_issues: if event == 'issues' and domain not in ('zulip.com', 'customer5.invalid', 'customer27.invalid', 'customer17.invalid') or exclude_issues:
return json_success() return json_success()
# CUSTOMER37 and CUSTOMER38 do not want github issues traffic, or push notifications, only pull requests.
if event in ('issues', 'issue_comment', 'push') and domain in ('customer37.invalid', 'customer38.invalid'):
return json_success()
# CUSTOMER23 doesn't want synchronize events for pull_requests
if event == "pull_request" and payload['action'] == "synchronize" and domain == "customer23.invalid":
return json_success()
### Zulip-specific logic ### Zulip-specific logic
# We currently handle push, pull_request, issues, issue_comment, commit_comment # We currently handle push, pull_request, issues, issue_comment, commit_comment
@@ -212,14 +203,6 @@ def api_github_landing(request, user_profile, event=REQ,
return json_success() return json_success()
if event == 'push': if event == 'push':
# This is a bit hackish, but is basically so that CUSTOMER18 doesn't
# get spammed when people commit to non-master all over the place.
# Long-term, this will be replaced by some GitHub configuration
# option of which branches to notify on.
# FIXME: get CUSTOMER18 to use the branch whitelist
if short_ref != 'master' and domain in ['customer18.invalid', 'zulip.com']:
return json_success()
# If we are given a whitelist of branches, then we silently ignore # If we are given a whitelist of branches, then we silently ignore
# any push notification on a branch that is not in our whitelist. # any push notification on a branch that is not in our whitelist.
if branches and short_ref not in re.split('[\s,;|]+', branches): if branches and short_ref not in re.split('[\s,;|]+', branches):