paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-20 22:48:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

message_list: Deduplicate stream muting live update code path.

Browse Source 
We can dramtically simplify the stream muting live-update code path
for updating home_msg_list by observing the only thing it was doing
intentionally differently from update_muting_and_rerender is replacing
_all_items with a new version computed from from all_messages_data,
and the rest of update_muting_and_rerender can handle the live update
correctly unmodified.

This deduplication means live-update of "Unmute topic" just requires
updating the `in:home` filter logic appropriately, without any special
live update work.
This commit is contained in:
Tim Abbott
2023-04-21 13:15:25 -07:00
parent 47b6bec0d4
commit ae314a3ca9
2 changed files with 22 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
web/src/message_list.js
View File

@@ -1,6 +1,7 @@
import autosize from "autosize";
import $ from "jquery";
import {all_messages_data} from "./all_messages_data";
import * as blueslip from "./blueslip";
import {MessageListData} from "./message_list_data";
import {MessageListView} from "./message_list_view";
@@ -426,6 +427,20 @@ export class MessageList {
}
update_muting_and_rerender() {
// For the home message list, we need to re-initialize
// _all_items for stream muting/topic unmuting from
// all_messages_data, since otherwise unmuting a previously
// muted stream won't work.
//
// TODO: The zhome conditional is a bit awkward, but a check
// for whether the filter excludes muted streams wouldn't be
// correct, because other narrows can't pull from
// all_messages.
if (this.table_name === "zhome") {
this.data.clear();
this.data.add_messages(all_messages_data.all_messages());
}
this.data.update_items_for_muting();
// We need to rerender whether or not the narrow hides muted
// topics, because we need to update recipient bars for topics