paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-13 02:17:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

notification_data: Annotate flags with Collection.

Browse Source 
Since `flags` here could be iterated through multiple times
(to check for push/email notifiability), we use `Collection`.
Inspired by 871e73ab8f.

The other change here in the `event_queue` code is prep for using
the `UserMessageNotificationsData` class there.
This commit is contained in:
Abhijeet Prasad Bodas
2021-06-21 18:55:47 +05:30
committed by Tim Abbott
parent 8182632d7e
commit aeb2ad5f46
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
zerver/lib/notification_data.py
View File

@@ -1,11 +1,11 @@
from dataclasses import dataclass from dataclasses import dataclass
from typing import List from typing import Collection
@dataclass @dataclass
class UserMessageNotificationsData: class UserMessageNotificationsData:
id: int id: int
flags: List[str] flags: Collection[str]
mentioned: bool mentioned: bool
online_push_enabled: bool online_push_enabled: bool
stream_push_notify: bool stream_push_notify: bool

2
zerver/tornado/event_queue.py
View File

@@ -948,7 +948,7 @@ def process_message_event(
for user_data in users: for user_data in users:
user_profile_id: int = user_data["id"] user_profile_id: int = user_data["id"]
flags: Iterable[str] = user_data.get("flags", []) flags: Collection[str] = user_data.get("flags", [])
# If the recipient was offline and the message was a single or group PM to them # If the recipient was offline and the message was a single or group PM to them
# or they were @-notified potentially notify more immediately # or they were @-notified potentially notify more immediately