paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-05 14:35:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Use early-return in extract_people_from_message().

Browse Source
This commit is contained in:
Steve Howell
2017-11-06 07:47:19 -08:00
committed by Tim Abbott
parent 294a1fb8f8
commit aebfdaa8ed
2 changed files with 29 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
static/js/people.js
View File

@@ -744,20 +744,23 @@ exports.extract_people_from_message = function (message) {
// Add new people involved in this message to the people list
_.each(involved_people, function (person) {
if (!person.unknown_local_echo_user) {
var user_id = person.user_id || person.id;
if (!people_by_user_id_dict.has(user_id)) {
exports.add({
email: person.email,
user_id: user_id,
full_name: person.full_name,
is_admin: person.is_realm_admin || false,
is_bot: person.is_bot || false,
});
}
if (person.unknown_local_echo_user) {
return;
}
var user_id = person.user_id || person.id;
if (people_by_user_id_dict.has(user_id)) {
return;
}
exports.add({
email: person.email,
user_id: user_id,
full_name: person.full_name,
is_admin: person.is_realm_admin || false,
is_bot: person.is_bot || false,
});
});
};